Skip to content

Add enhancement export tenant layer#689

Closed
mithunbharadwaj wants to merge 5 commits intomasterfrom
Enhancement/Export-tenant-layer
Closed

Add enhancement export tenant layer#689
mithunbharadwaj wants to merge 5 commits intomasterfrom
Enhancement/Export-tenant-layer

Conversation

@mithunbharadwaj
Copy link
Copy Markdown
Collaborator

No description provided.

@mithunbharadwaj mithunbharadwaj self-assigned this Jun 10, 2025
@mithunbharadwaj mithunbharadwaj requested a review from ateska June 12, 2025 06:30
@mithunbharadwaj mithunbharadwaj requested review from ateska and removed request for ateska June 14, 2025 09:00
Comment thread asab/library/service.py Outdated
tarobj.addfile(tarinfo=info, fileobj=my_data)
tarobj.addfile(tarinfo=info, fileobj=data)

# -- Tenant layers --
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenant and global layers will be mixed, so re-import will destroy the correct content of the library.
This is not a correct design.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ateska All the tenant contents will be copied to /tenants/ is that wrong to create the separation between tenant and global?

If so what is the correct approach?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - but the export is done for a specific tenant - so only 1 tenant instance will be present in /tenants/

Comment thread asab/library/service.py Outdated
tarobj.addfile(tarinfo=info, fileobj=my_data)
tarobj.addfile(tarinfo=info, fileobj=data)

# -- Tenant layers --
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - but the export is done for a specific tenant - so only 1 tenant instance will be present in /tenants/

@mithunbharadwaj mithunbharadwaj requested a review from ateska June 25, 2025 08:59
Mithun Shivashankar added 2 commits June 30, 2025 08:46
@ateska
Copy link
Copy Markdown
Contributor

ateska commented Jul 10, 2025

This looks ok - can you please demonstrate on review a process of export & import?

@mithunbharadwaj
Copy link
Copy Markdown
Collaborator Author

Closing this. Solved it here (#733)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants